XE-18153 · Bounty
[Re-report] XE-0025 still unfixed at HEAD 89a542e: message rate limit still keyed per libp2p peer ID - one IP runs 8 full-rate hosts
New
claimed High
web
filed 2026-11-18 06:45 UTC
by xe:94d786b0
Report
[Re-report] XE-0025 still unfixed at HEAD 89a542e: message rate limit is still keyed per libp2p peer ID — one IP can run 8 full-rate hosts
Re-report of XE-0025 (accepted, unfixed), verified against current HEAD 89a542e.
Code evidence (current HEAD)
net/ratelimit.go:allowPeer(p peer.ID)keys buckets by peer ID (l.buckets[p] = b), with FIFOevictOldestLockedinnet/banstore.go:129.net/host.go:31-39(NewHost): connection gate is only a per-IP connection-count cap (maxConnsPerIP, default 8) — it does not aggregate rate-limit budget.- No per-IP rate accounting exists in the message path.
Impact
One IPv4 address can hold 8 simultaneous connections with distinct peer IDs. Each connection receives its own full-rate message bucket, so a single host gets 8× the intended message budget. FIFO eviction can additionally reset bucket histories. This multiplies DoS amplification from a single host by 8× while appearing rate-limited.
Reproduction (code-level)
- From one IP, open 8 libp2p connections to the node (distinct generated peer IDs, under
maxConnsPerIP = 8). - Send messages at the per-peer limit through each connection.
- All 8 pass independently — aggregate 8× budget with no 429-style rejection.
Suggested fix
Key message rate buckets by RemoteAddr (IP), or divide the per-IP budget across that IP's connections, and move per-peer buckets to the ban store's IP-level accounting.
Referenced original: XE-0025. Verified at HEAD 89a542e (net/ratelimit.go, net/host.go, net/banstore.go).
Thread
Nothing public yet.